api clients: return data, error, no status

jellyseerr already did this, but it's been standardised a little more.

Mediabrowser uses it's own genericErr function and error types due to
being a separate package, while jellyseerr and ombi now share errors
defined in common/.
This commit is contained in:
Harvey Tindall
2024-08-06 14:48:31 +01:00
parent 284312713c
commit 2310130e6b
28 changed files with 327 additions and 308 deletions
+3 -3
View File
@@ -24,8 +24,8 @@ func (app *appContext) checkUsers() {
}
app.info.Println(lm.CheckUserExpiries)
users, status, err := app.jf.GetUsers(false)
if err != nil || status != 200 {
users, err := app.jf.GetUsers(false)
if err != nil {
app.err.Printf(lm.FailedGetUsers, lm.Jellyfin, err)
return
}
@@ -89,7 +89,7 @@ func (app *appContext) checkUsers() {
err, _, _ = app.SetUserDisabled(user, true)
activity.Type = ActivityDisabled
}
if !(status == 200 || status == 204) || err != nil {
if err != nil {
app.err.Printf(lm.FailedDeleteOrDisableExpiredUser, user.ID, err)
continue
}